Deprecate best_transactions_with_base_fee
#6394
Conversation
There was a problem hiding this comment.
this is a good start,
what's missing is blob fee handling:
after we check the directional swing of the base fee we also need to take the swing of the blob into account because a lower blobfee can unlock more eip4844 txs from the blob pool and a higher can prevent currently pending blobs in the pending pool
mattsse
added
C-enhancement
Co-authored-by: Matthias Seitz <[email protected]>
|
@mattsse As we will migrate to Cancun, why not using normal |
@mattsse We agree that these changes should be made in a separate PR in response to #6383 no? |
| @@ -421,7 +421,7 @@ where | |||
| &self, | |||
| base_fee: u64, | |||
| ) -> Box<dyn BestTransactions<Item = Arc<ValidPoolTransaction<Self::Transaction>>>> { | |||
| self.pool.best_transactions_with_base_fee(base_fee) | |||
| self.pool.best_transactions_with_attributes(BestTransactionsAttributes::base_fee(base_fee)) | |||
There was a problem hiding this comment.
@mattsse I just did an update, this is the only place where I use the base fee initializer. On the other places, I use an initialization taking into account the gas price of the blob and if there is no blob, then the Option will just return a None and it will have the same effect as the base fee initializer in my opinion.
Tell me what you think?
right, that is appropriate, so we limit this pr to deprecating the function |
Should close #6382.