-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minimum check in check_gas_limit
with unit test
#6157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
pending @Rjected
Co-authored-by: Matthias Seitz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@mattsse Small question here: as the |
good point, technically this doesn't require the parent block and could/should be performed when we validate the header standalone I also see that we have a few functions that we don't use like and honestly, I'm not super happy with the function name inconsistencies like
|
Co-authored-by: Matthias Seitz <[email protected]>
Description
This pull request introduces a minimum gas limit check within the
check_gas_limit
function, accompanied by a corresponding unit test.Changes Made
MINIMUM_GAS_LIMIT
) in thecheck_gas_limit
function.test_gas_limit_below_limit
) to verify that the minimum gas limit check is functioning correctly.Motivation
Ensuring that the child gas limit does not go below a specified minimum is crucial for maintaining network integrity. This addition helps prevent gas limit values that could potentially cause issues within the Ethereum consensus.