Prioritise primary stream #6086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jan 16, 2024
crates/net/eth-wire/src/multiplex.rs
Outdated
| Poll::Ready(None) => return Poll::Ready(None), | ||
| Poll::Pending => { | ||
| this.inner.protocols.push(proto); | ||
| break |
There was a problem hiding this comment.
this break will terminate the for loop now, but we still want to advance the remaining streams, right?
perhaps we should rewrite protocols: Vec<ProtocolStream> as
FuturesUnordered<StreamFuture<ProtocolStream>
see also SelectAll impl
https://docs.rs/futures-util/0.3.30/src/futures_util/stream/select_all.rs.html#93
There was a problem hiding this comment.
absolutely. I also found some more code that impedes us from prioritising the primary stream, fixed it in the latest commit.
mattsse
added
C-perf
|
stoping development, in favour of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
programmability spans up a new attack surface onto the node. this pr prioritises the primary stream. it is a good precaution that aims to limit the damage of user-defined vulnerabilities to the injected handles, and not let them effect the whole node.
by letting users inject cap-handles into reth, we are making the node vulnerable to all kinds of errors we cannot foresee and therefore not make any guarantees for how the node runs. a scenario that could happen before, is that some user-defined cap-handle can be dos:ed so that it sends endless messages, this means that the
RlpxSatelliteStreamstream will get stuck in a loop and no moreethmessages would be sent or received.