Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: also adjust ipc path #5909

Merged
merged 1 commit into from
Dec 31, 2023
Merged

fix: also adjust ipc path #5909

merged 1 commit into from
Dec 31, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 31, 2023

Closes #5907

the ipc path wasn't adjusted when running multiple instances leading to race conditions in the rpc setup

@mattsse mattsse requested a review from onbjerg as a code owner December 31, 2023 06:53
@mattsse mattsse requested review from Rjected and removed request for onbjerg December 31, 2023 06:53
@mattsse mattsse added the C-bug An unexpected or incorrect behavior label Dec 31, 2023
Rjected
Rjected approved these changes Dec 31, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense that this would cause the issue, good solution

@Rjected Rjected added this pull request to the merge queue Dec 31, 2023
Merged via the queue into main with commit 069ca82 Dec 31, 2023
27 checks passed
@Rjected Rjected deleted the matt/adjust-ipc-path-instance branch December 31, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local test: all features failed in node_builder-related unit tests.
2 participants
@mattsse @Rjected