Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: small refactoring for Header structure #5801

Merged
merged 4 commits into from
Dec 18, 2023
Merged

refactor: small refactoring for Header structure #5801

merged 4 commits into from
Dec 18, 2023

Conversation

tcoratger
Copy link
Contributor

This PR introduces improved documentation and minor refactoring for the Header structure.

@tcoratger tcoratger requested a review from gakonst as a code owner December 17, 2023 15:53
onbjerg
onbjerg approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg changed the title add documentation and small refactoring for Header structure refactor: small refactoring for Header structure Dec 18, 2023
@onbjerg onbjerg added the C-debt A clean up/refactor of existing code label Dec 18, 2023
mattsse
mattsse approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is helpful

@mattsse mattsse enabled auto-merge December 18, 2023 08:06
@mattsse mattsse added this pull request to the merge queue Dec 18, 2023
Merged via the queue into paradigmxyz:main with commit fb871bf Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @onbjerg @mattsse