Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use nybbles crate #5766

Merged
merged 1 commit into from
Dec 15, 2023
Merged

feat: use nybbles crate #5766

merged 1 commit into from
Dec 15, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Dec 15, 2023 •
edited
Loading

@DaniPopes DaniPopes requested a review from mattsse December 15, 2023 09:39
@onbjerg
Copy link
Collaborator

onbjerg commented Dec 15, 2023

any way we can avoid the .0 in the crate?

@DaniPopes
Copy link
Member Author

DaniPopes commented Dec 15, 2023 •
edited
Loading

Need a wrapper for Codec impl, it was like this before too

mattsse
mattsse approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 26a91c6 Dec 15, 2023
@onbjerg onbjerg deleted the dani/nybbles branch December 15, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @onbjerg @mattsse