Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sequential_transactions_by_sender method for MockTransactionSet #5741

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

tcoratger
Copy link
Contributor

Added a new method sequential_transactions_by_sender to the MockTransactionSet struct.

This method generates a sequence of transactions for a specified sender, creating a chain based on the provided transaction count.

@tcoratger tcoratger requested a review from mattsse as a code owner December 12, 2023 17:36
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this overall, just one comment so we have less code duplication

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@mattsse mattsse added this pull request to the merge queue Dec 15, 2023
Merged via the queue into paradigmxyz:main with commit ed7e6af Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants