Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add MockTransactionSet for easier dependent mock txs #5633

Merged
merged 4 commits into from
Nov 30, 2023
Merged

feat: add MockTransactionSet for easier dependent mock txs #5633

merged 4 commits into from
Nov 30, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Nov 30, 2023

Adds MockTransactionSet, which makes it easier to construct dependent chains of MockTransactions that have the same sender. This is useful when creating test cases for transaction pool methods which operate based on senders, like truncate_pool and get_senders_by_submission_id.

@Rjected Rjected added A-tx-pool Related to the transaction mempool C-test A change that impacts how or what we test labels Nov 30, 2023
@Rjected Rjected requested a review from mattsse as a code owner November 30, 2023 04:20
mattsse
mattsse approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rjected Rjected added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit aabb58d Nov 30, 2023
@Rjected Rjected deleted the dan/mock-transaction-set branch November 30, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse