Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op-reth): Remove Canyon hardfork warning #5551

Merged
merged 1 commit into from
Nov 27, 2023
Merged

feat(op-reth): Remove Canyon hardfork warning #5551

merged 1 commit into from
Nov 27, 2023

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Nov 23, 2023 •
edited
Loading

Overview

Note: This is the sixth and final PR in the Canyon HF stack. Precedence:
#5551
-> #5542
--> #5527
---> #5526
----> #5504
-----> #5503
------> main

Removes the Canyon warning in the op-reth binary + book.

@clabby clabby added the A-op-reth Related to Optimism and op-reth label Nov 23, 2023
rkrasiuk
rkrasiuk approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from ef06aa8 to 26fea54 Compare November 23, 2023 23:34
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from f61e6de to ed07053 Compare November 23, 2023 23:38
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from 26fea54 to 8631b95 Compare November 23, 2023 23:44
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from ed07053 to 1f9da31 Compare November 23, 2023 23:44
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from 8631b95 to 7db1c22 Compare November 24, 2023 00:25
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from 1f9da31 to e463598 Compare November 24, 2023 00:25
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from 7db1c22 to a97b6a5 Compare November 24, 2023 00:49
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from e463598 to 0a447a7 Compare November 24, 2023 00:49
@clabby clabby marked this pull request as ready for review November 24, 2023 00:56
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from a97b6a5 to 48532af Compare November 24, 2023 01:01
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from 0a447a7 to b82e425 Compare November 24, 2023 01:01
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from 48532af to 6916393 Compare November 24, 2023 01:03
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from b82e425 to d3563b4 Compare November 24, 2023 01:03
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from 6916393 to c5899c3 Compare November 24, 2023 15:33
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from d3563b4 to b3210c4 Compare November 24, 2023 15:33
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from c5899c3 to 98430a9 Compare November 24, 2023 15:38
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from b3210c4 to 3961604 Compare November 24, 2023 15:38
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from 98430a9 to 0b31dfc Compare November 24, 2023 15:40
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from 3961604 to e4a7e13 Compare November 24, 2023 15:40
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from 0b31dfc to f6974df Compare November 24, 2023 15:44
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from e4a7e13 to 6431063 Compare November 24, 2023 15:44
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from f6974df to 1781791 Compare November 24, 2023 15:49
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch 2 times, most recently from e9a5e64 to 8b85eda Compare November 24, 2023 16:11
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from 8c6e1df to 3acd79a Compare November 24, 2023 16:13
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch 2 times, most recently from ecd47da to a09454a Compare November 24, 2023 16:13
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from 52fcac7 to d7ef114 Compare November 24, 2023 17:31
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch 2 times, most recently from ed72b47 to 3923963 Compare November 26, 2023 17:21
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from f6a7aea to a8de41d Compare November 26, 2023 18:55
@clabby clabby requested a review from Evalir as a code owner November 26, 2023 18:55
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch 2 times, most recently from ebd2a6d to 75d83d5 Compare November 27, 2023 14:22
@clabby clabby force-pushed the cl/op/canyon-hf-dynamic-eip1559-params branch from f70e3eb to f69edcc Compare November 27, 2023 16:48
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from 75d83d5 to e87f390 Compare November 27, 2023 16:49
Base automatically changed from cl/op/canyon-hf-dynamic-eip1559-params to main November 27, 2023 17:36
@mattsse mattsse added this pull request to the merge queue Nov 27, 2023
@clabby clabby removed this pull request from the merge queue due to a manual request Nov 27, 2023
@clabby clabby force-pushed the cl/op/canyon-hf-remove-warning branch from e87f390 to 4033c0a Compare November 27, 2023 17:58
@clabby clabby enabled auto-merge November 27, 2023 17:58
@clabby clabby mentioned this pull request Nov 27, 2023
Closed
@clabby clabby added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit 8161c26 Nov 27, 2023
@clabby clabby deleted the cl/op/canyon-hf-remove-warning branch November 27, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@Rjected Rjected Awaiting requested review from Rjected

@rakita rakita Awaiting requested review from rakita

@joshieDo joshieDo Awaiting requested review from joshieDo

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clabby @mattsse @rkrasiuk