perf(provider): compute hashes and trie updates before opening write tx #5505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-perf
rkrasiuk
commented
Nov 20, 2023
crates/storage/provider/src/bundle_state/bundle_state_with_receipts.rs
Outdated
Show resolved
Hide resolved
shekhirin
reviewed
Nov 21, 2023
| @@ -2321,7 +2323,11 @@ impl<TX: DbTxMut + DbTx> BlockWriter for DatabaseProvider<TX> { | |||
| state.write_to_db(self.tx_ref(), OriginalValuesKnown::No)?; | |||
| durations_recorder.record_relative(metrics::Action::InsertState); | |||
|
|
|||
| self.insert_hashes(first_number..=last_block_number, last_block_hash, expected_state_root)?; | |||
There was a problem hiding this comment.
there's now insert_hashes inside the provider and new HashedStateChanges::write_to_db, can we merge them somehow? IIUC the provider one is used now only in the test
There was a problem hiding this comment.
we might want to remove insert_hashes, will think about it
|
|
||
| impl HashedStateChanges { | ||
| /// Write the bundle state to the database. | ||
| pub fn write_to_db<TX: DbTxMut + DbTx>(self, tx: &TX) -> Result<(), DatabaseError> { |
There was a problem hiding this comment.
it would be nice to add the timings breakdown here too, same as in insert_hashes
There was a problem hiding this comment.
also a bit concerning that this is almost the same logic as in insert_(account|storage)_for_hashing
There was a problem hiding this comment.
will address in a follow up
mattsse
approved these changes
Nov 27, 2023
shekhirin
approved these changes
Nov 27, 2023
rkrasiuk
force-pushed
the
rkrasiuk/compute-before-write
branch
from
31a72d7 to
25c8129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of the freelist saga #5228
This PR aims to decrease the duration for which the write transaction is open during canonical commit. This is done by computing state hashes and merkle root with updates before opening a write transaction.