Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pipeline): stage poll extension trait #5484

Merged
merged 2 commits into from
Nov 18, 2023
Merged

chore(pipeline): stage poll extension trait #5484

merged 2 commits into from
Nov 18, 2023

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Nov 18, 2023 •
edited
Loading

Description

Create StageExt trait for invoking Stage::poll_execute_ready with poll_fn context.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-staged-sync Related to staged sync (pipelines and stages) labels Nov 18, 2023
@rkrasiuk rkrasiuk requested a review from mattsse November 18, 2023 08:02
mattsse
mattsse approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming nit

@rkrasiuk rkrasiuk enabled auto-merge November 18, 2023 08:34
@rkrasiuk rkrasiuk added this pull request to the merge queue Nov 18, 2023
Merged via the queue into main with commit c7a57a7 Nov 18, 2023
@rkrasiuk rkrasiuk deleted the rkrasiuk/stage-poll-ext branch November 18, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-staged-sync Related to staged sync (pipelines and stages) C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse