Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ckzg dep from rpc types #5392

Merged
merged 2 commits into from
Nov 13, 2023
Merged

chore: remove ckzg dep from rpc types #5392

merged 2 commits into from
Nov 13, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 11, 2023

removes ckzg dep from rpc-types

used transmute for conversion between rpc and primitive, since same layout, Fixedbytes is just a transparent array

but can make this safe with

ethereum/c-kzg-4844#380

@mattsse mattsse mentioned this pull request Nov 11, 2023
Merged
@mattsse mattsse force-pushed the matt/remove-ckzg-dep branch from 5d730be to f54013c Compare November 11, 2023 13:02
@mattsse mattsse requested a review from onbjerg as a code owner November 11, 2023 13:12
@mattsse mattsse force-pushed the matt/remove-ckzg-dep branch from eb5cba6 to 617f910 Compare November 11, 2023 13:12
onbjerg
onbjerg approved these changes Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but sort of uneasy w unsafe, means we have to be extra careful when changing any of the related types in case mem layout changes

@mattsse mattsse added this pull request to the merge queue Nov 13, 2023
Rjected
Rjected approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the transmute should be fine for now

Merged via the queue into main with commit 79abf2b Nov 13, 2023
@mattsse mattsse deleted the matt/remove-ckzg-dep branch November 13, 2023 17:46
mattsse added a commit that referenced this pull request Nov 14, 2023
@mattsse
chore: remove ckzg dep from rpc types (#5392)
4fbaac6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg onbjerg approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @Rjected @onbjerg