-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/enable non namespaces #5391
Feat/enable non namespaces #5391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty!
I believe this can be supported with two checks in rpc modulesecltion parser instead
check for none|None
and is_empty
where is_empty is the first check on s
Thanks @mattsse , everything seems to work. I am not too sure we require the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @mattsse as agreed I am opening this PR in order to enable to start a reth node with empty http.api modules. This is required for any user who just wants to enable some custom RPC namespace.