Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/enable non namespaces #5391

Merged
merged 5 commits into from
Nov 11, 2023
Merged

Feat/enable non namespaces #5391

merged 5 commits into from
Nov 11, 2023

Conversation

loocapro
Copy link
Contributor

Hi @mattsse as agreed I am opening this PR in order to enable to start a reth node with empty http.api modules. This is required for any user who just wants to enable some custom RPC namespace.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

I believe this can be supported with two checks in rpc modulesecltion parser instead

check for none|None and is_empty

where is_empty is the first check on s

@loocapro
Copy link
Contributor Author

ty!

I believe this can be supported with two checks in rpc modulesecltion parser instead

check for none|None and is_empty

where is_empty is the first check on s

Thanks @mattsse , everything seems to work. I am not too sure we require the s.is_empty()check as the cli args gets validated and i cannot seem to pass an empty --http.api.

@loocapro loocapro marked this pull request as ready for review November 11, 2023 14:49
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Nov 11, 2023
@mattsse mattsse added the A-cli Related to the reth CLI label Nov 11, 2023
Merged via the queue into paradigmxyz:main with commit 7734ab7 Nov 11, 2023
mattsse pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants