feat: support hello message with protocols #5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
approved these changes
Nov 9, 2023
Comment on lines
-693
to
+706
|
|
||
| let shared_capability = SharedCapability::new(&name, *version as u8, offset)?; | ||
|
|
||
| match shared_capability { | ||
| SharedCapability::UnknownCapability { .. } => { | ||
| // Capabilities which are not shared are ignored | ||
| debug!("unknown capability: name={:?}, version={}", name, version,); | ||
| let proto_version = shared_capabilities.get(&name).expect("shared; qed"); | ||
|
|
||
| // TODO(mattsse): track shared caps | ||
| } | ||
| SharedCapability::Eth { .. } => { | ||
| // increment the offset if the capability is known | ||
| offset += shared_capability.num_messages()?; | ||
| let shared_capability = SharedCapability::new(&name, proto_version.version as u8, offset)?; | ||
|
|
||
| shared_with_offsets.push(shared_capability); | ||
| } | ||
| } | ||
| offset += proto_version.messages; | ||
| shared_with_offsets.push(shared_capability); |
There was a problem hiding this comment.
ah, this sense compared to the match, SharedCapability would have had to be extended for people adding new subprotocols. Whereas this is more flexible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
ProtocolsandHelloMessageWithProtocolstype, which is now required when handshaking p2p stream.this way we can support any protocol, because message numbers are not exchanged via the handshake we need to rely on input data when computing the offsets for sharedcapabilities.
The
Protocolstype provides this additional information.This will require a few followups to make it a bit nicer overall