-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc-builder): test requests params #5267
feat(rpc-builder): test requests params #5267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot,
smol nit, then we can put this to work to a few more endpoints
fn build(self) -> String { | ||
json!({ | ||
"jsonrpc": "2.0", | ||
"id": self.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs unwrap or default otherwise this can serialize to null, which is invalid rpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs unwrap or default otherwise this can serialize to null, which is invalid rpc
Does the changes looks better?
Thank you so much, this is thanks to your advice in the issue #5234 |
@DoTheBestToGetTheBest |
I'm having a bit of trouble debugging this, I can't run cargo test on my computer. But I promise I'll see it again soon! |
"jsonrpc": "2.0", | ||
"id": id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch these and test should work!
I found new way to implement build function to basically guarante that the order of data will be as needed. |
i'm converting this in draft, i'm having some difficulty to understand what i need to do now
if possible to get some help on this please