refactor: Add more low-level methods to Executor
#14440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez,
rakita and
gakonst
as code owners
klkvr
force-pushed
the
klkvr/refactor-executor
branch
from
73d415f to
c277b7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to unify
ExecutorandBatchExecutor. The only difference between them is thatExecutor::executealways consumesselfnot allowing for reuse of executor or innerState, andBatchExecutorexposesexecute_and_verify_onewhich applies the state changes to&mut self.This PR changes
Executorto contain low-levelexecute_oneandexecute_one_with_state_hookwhich are similar toBatchExecutor::execute_and_verify_one. The only difference is that they do not perfom validation, and instead returnBlockExecutionResult, containing receipts and requests which can be used for validation on callsite instead.