Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op, txpool): impl send_raw_tx_cond endpoint #14311

Merged
merged 13 commits into from
Feb 10, 2025
Merged

feat(op, txpool): impl send_raw_tx_cond endpoint #14311

merged 13 commits into from
Feb 10, 2025

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Feb 7, 2025 •
edited
Loading

Towards #14194

@fgimenez fgimenez added A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Feb 7, 2025
mattsse
mattsse requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start,

the state validation stuff we can do later.

a few suggestions

@emhane emhane mentioned this pull request Feb 8, 2025
Closed
@fgimenez fgimenez force-pushed the fgimenez/impl-send-raw-tx-cond-endpoint branch 3 times, most recently from 039ee6c to 69661e8 Compare February 10, 2025 11:39
@fgimenez fgimenez marked this pull request as ready for review February 10, 2025 12:37
mattsse
mattsse requested changes Feb 10, 2025
View reviewed changes
@fgimenez fgimenez force-pushed the fgimenez/impl-send-raw-tx-cond-endpoint branch from 9b28846 to cd2d120 Compare February 10, 2025 15:51
@fgimenez fgimenez force-pushed the fgimenez/impl-send-raw-tx-cond-endpoint branch from 4b9ce95 to fb1cedf Compare February 10, 2025 16:52
mattsse
mattsse approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm

we can add support for submitting the tx with conditional into the pool as followup

crates/optimism/rpc/src/eth/ext.rs Outdated
Comment on lines 99 to 102
// otherwise, add to pool
let hash = self.pool().add_transaction(TransactionOrigin::External, tx).await.map_err(
|e| OpEthApiError::Eth(reth_rpc_eth_types::EthApiError::PoolError(e.into())),
)?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can submit it like this, because this now removes the conditional?

let's say this is the sequencer instance, then this now simply inserts the tx as regular tx?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep exactly, added todo comment

@fgimenez fgimenez added this pull request to the merge queue Feb 10, 2025
@mattsse mattsse mentioned this pull request Feb 10, 2025
Closed
Merged via the queue into main with commit fe32237 Feb 10, 2025
44 checks passed
@fgimenez fgimenez deleted the fgimenez/impl-send-raw-tx-cond-endpoint branch February 10, 2025 18:30
@mattsse mattsse mentioned this pull request Feb 10, 2025
Closed
18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
@fgimenez @18aaddy
feat(op, txpool): impl send_raw_tx_cond endpoint (paradigmxyz#14311)
876054c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgimenez @mattsse