feat: abstract OpPooledTransaction and OpPool over consensus tx
#14256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/generic-op-pooled
branch
from
7dd7319 to
d3bd76d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
PoolTransactiontrait is simplified to not have any conversion traits as supertraits. Core conversions are now defined asSelf::from_pooled,Self::into_consensusandPooled: TryFrom<Consensus>where the latter is responsible for stripping all tx variants that can't be pooled.OpPooledTransactionis made generic over both consensus and pooled tx. This is a bit ugly but it seems that we can't do much better unfortunately. IdeallyPoolTransaction::Pooledshould not exist, and the conversion intoPooledvariant should be done somewhere closer to networking (which is the only consumer of the conversion)OpPoolandOpPoolBuilderare made generic over pool transaction, allowing them to no longer lock tx toOpPooledTransaction