feat: track max blobcount in forktracker #14231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Feb 5, 2025
Comment on lines
556
to
557
| /// Max blob count at the block's timestamp. | ||
| max_blob_count: AtomicU64, |
There was a problem hiding this comment.
this needs to be a simple u64 here
| .chain_spec() | ||
| .blob_params_at_timestamp(timestamp) | ||
| .map(|p| p.max_blob_count) | ||
| .unwrap_or(0) |
There was a problem hiding this comment.
this we can't do, we should always use MAX_BLOBS_PER_BLOCK
| @@ -752,6 +772,7 @@ impl<Client> EthTransactionValidatorBuilder<Client> { | |||
| shanghai: AtomicBool::new(shanghai), | |||
| cancun: AtomicBool::new(cancun), | |||
| prague: AtomicBool::new(prague), | |||
| max_blob_count: AtomicU64::new(MAX_BLOBS_PER_BLOCK as u64), | |||
There was a problem hiding this comment.
oh here we actually need to check if prague then BlobParams::prague, otherwise BlobParams::cancun blobcount
| @@ -340,14 +340,14 @@ where | |||
| ) | |||
| } | |||
|
|
|||
| if blob_count > MAX_BLOBS_PER_BLOCK { | |||
| // too many blobs | |||
| let max_blob_count = self.fork_tracker.max_blob_count().try_into().unwrap(); | |||
There was a problem hiding this comment.
here you can simply cast this as usize
mattsse
added
A-tx-pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14227 #14226