feat(chainspec): add Chainspec::blob_fee_params_at_timestamp #14049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TropicalDog17
requested review from
Rjected,
joshieDo and
mattsse
as code owners
mattsse
requested changes
Jan 28, 2025
crates/chainspec/src/spec.rs
Outdated
| @@ -385,7 +385,7 @@ impl ChainSpec { | |||
| // given timestamp. | |||
| for (fork, params) in bf_params.iter().rev() { | |||
| if self.hardforks.is_fork_active_at_timestamp(fork.clone(), timestamp) { | |||
| return *params | |||
| return *params; | |||
There was a problem hiding this comment.
Suggested change
| return *params; | |
| return *params |
crates/chainspec/src/spec.rs
Outdated
| @@ -404,7 +404,7 @@ impl ChainSpec { | |||
| // given timestamp. | |||
| for (fork, params) in bf_params.iter().rev() { | |||
| if self.hardforks.is_fork_active_at_block(fork.clone(), block_number) { | |||
| return *params | |||
| return *params; | |||
There was a problem hiding this comment.
Suggested change
| return *params; | |
| return *params |
crates/chainspec/src/spec.rs
Outdated
Comment on lines
419
to
422
| if self.is_cancun_active_at_timestamp(timestamp) { | ||
| Some(cancun) | ||
| } else if self.is_prague_active_at_timestamp(timestamp) { | ||
| Some(prague) |
There was a problem hiding this comment.
can we flip the order here starting with the highest (prague)
crates/chainspec/src/spec.rs
Outdated
| @@ -413,6 +413,18 @@ impl ChainSpec { | |||
| } | |||
| } | |||
|
|
|||
| /// Get the blob fee parameters for the given timestamp. | |||
| pub fn blob_fee_params_at_timestamp(&self, timestamp: u64) -> Option<BlobParams> { | |||
There was a problem hiding this comment.
can we also make this part of the chainspec trait?
mattsse
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14042