feat: introduce ProviderFactoryBuilder #13989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
rakita,
joshieDo,
shekhirin,
Rjected and
gakonst
as code owners
mattsse
added
C-enhancement
Rjected
reviewed
Jan 26, 2025
|
|
||
| impl<N> ProviderFactoryBuilder<N> { | ||
| /// Maps the [`NodeTypes`] of this builder. | ||
| pub fn types<T>(self) -> ProviderFactoryBuilder<T> { |
There was a problem hiding this comment.
How would this fn be used? Would it be used in combination with eg a constructor method on ProviderFactoryBuilder<()>
So the pattern would be something like
// Hopefully don't have to specify N for Default if planning on configuring types with the fn
let builder = ProviderFactoryBuilder::default()
.types(types)
.db(db)
.chain_spec(spec)
.static_files(sf)
.build()
Rjected
approved these changes
Jan 28, 2025
Comment on lines
+98
to
+113
| /// Settings for how to open the database and static files. | ||
| /// | ||
| /// The default derivation from a path assumes the path is the datadir: | ||
| /// [`ReadOnlyConfig::from_datadir`] | ||
| #[derive(Debug, Clone)] | ||
| pub struct ReadOnlyConfig { | ||
| /// The path to the database directory. | ||
| pub db_dir: PathBuf, | ||
| /// How to open the database | ||
| pub db_args: DatabaseArguments, | ||
| /// The path to the static file dir | ||
| pub static_files_dir: PathBuf, | ||
| /// Whether the static files should be watched for changes. | ||
| pub watch_static_files: bool, | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #13988
this is far from done, hence this doesn't update all
ProviderFactory::newinstances.This is introduces a builder helper type for the ProviderFactory.
it is intended that this will be instantiated via the node type (
EthereumNode::provider_factory_builder).This Pr introduces various builder stage types,
TypesAndXthat could potentially be reused for additional builders.their purpose is to attach additional values and steer the user via appropriately named functions.
As followup, I'll look at making db+static file instantiation easier and make this a single builder call.
this pr is the first step to keep changes small