refactor: mv proofs mod to reth-primitives-traits and split tests #13871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lean-apple
commented
Jan 20, 2025
Comment on lines
+210
to
+213
| /// Ethereum full block. | ||
| /// | ||
| /// Withdrawals can be optionally included at the end of the RLP encoded message. | ||
| pub(crate) type Block<T = TransactionSigned> = alloy_consensus::Block<T>; |
There was a problem hiding this comment.
I push this in that way, as it is only used for tests, otherwise I can probably put in a mod or lib
lean-apple
requested review from
mattsse,
Rjected,
joshieDo,
klkvr,
rakita and
gakonst
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13851.
Add duplicate
reth-primitives-traits::proofs.Move
calculate_receipt_root_no_memotoethereum-primitives::ReceiptMove tests
check_transaction_root,check_withdrawals_rootalso toethereum-primitives::receiptmod.I want to do in another pr the complete removal of
reth-primitives::proofsand update all thereth-primitives::proofstoreth-primitives-traits::proofs.