feat: get BlockMeta table values from static file or database
#13844
+70
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-enhancement
joshieDo
force-pushed
the
joshie/providersmeta
branch
from
8589272 to
a5080e2
Compare
joshieDo
commented
Jan 17, 2025
| @@ -171,7 +173,7 @@ where | |||
| let ommers = if chain_spec.final_paris_total_difficulty(header.number).is_some() { | |||
| Vec::new() | |||
| } else { | |||
| ommers_cursor.seek_exact(header.number)?.map(|(_, o)| o.ommers).unwrap_or_default() | |||
| provider.ommers(header.number.into())?.unwrap_or_default() | |||
There was a problem hiding this comment.
smol perf hit since it's no longer using a cursor, but since it's just ommers i'd be okay with it. The alternative is to implement Provider::ommers_range.
I do plan to add withdrawals_range since it's actually used today
joshieDo
changed the title
BlockMeta tables from static file or databaseBlockMeta table values from static file or database
joshieDo
commented
Jan 17, 2025
| Provider: DBProvider + ChainSpecProvider<ChainSpec: EthereumHardforks>, | ||
| Provider: DBProvider | ||
| + ChainSpecProvider<ChainSpec: EthereumHardforks> | ||
| + OmmersProvider<Header = Header>, |
There was a problem hiding this comment.
necessary since BlockBody expects Vec<Header> as Ommers
klkvr
approved these changes
Jan 17, 2025
| @@ -562,14 +562,29 @@ impl<N: ProviderNodeTypes> BlockBodyIndicesProvider for ProviderFactory<N> { | |||
| &self, | |||
| number: BlockNumber, | |||
| ) -> ProviderResult<Option<StoredBlockBodyIndices>> { | |||
| self.provider()?.block_body_indices(number) | |||
| self.static_file_provider.get_with_static_file_or_database( | |||
There was a problem hiding this comment.
this should still delegate to the self.provider() I think? given that it already does get_with_static_file_or_database internally
There was a problem hiding this comment.
this way a database transaction wont get opened unless truly necessary
refcell
pushed a commit
to ethereum-optimism/op-reth
that referenced
this pull request
Jan 24, 2025
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
get_with_static_file_or_databaseandget_range_with_static_file_or_databasein provider implementations forOmmers,WithdrawalsandBlockBodyIndices.Since the block meta static file isn't being written to yet, it shouldn't have any meaningful effect. Just spreading out the change into smaller PRs.