Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trie): reveal blinded node along with masks in sparse trie #13827

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jan 16, 2025

I was so wrong here

// We'll never have to update the revealed child node, only
// remove or do nothing, so
// we can safely ignore the hash mask here and
// pass `None`.

We actually need masks for revealed blinded nodes, because we need to calculate the tree mask of a new branch node correctly, and for that we need to know the masks of children branch nodes.

This PR fixes the trie updates mismatch on Holesky block 3157051.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-trie Related to Merkle Patricia Trie implementation labels Jan 16, 2025
@shekhirin shekhirin marked this pull request as ready for review January 16, 2025 17:53
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

><

@shekhirin shekhirin added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 43bd94a Jan 17, 2025
43 checks passed
@shekhirin shekhirin deleted the alexey/blinded-node-bug-idk branch January 17, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants