Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher limit for total_difficulty.bit_len #13820

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Higher limit for total_difficulty.bit_len #13820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d8b4f1
increased total_difficulty.bit_len limit
debjit-bw Jan 16, 2025
bdafc80
tests fix
debjit-bw Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crates/net/eth-wire/src/ethstream.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,12 @@ where
}

// TD at mainnet block #7753254 is 76 bits. If it becomes 100 million times
// larger, it will still fit within 100 bits
if status.total_difficulty.bit_len() > 100 {
// larger, it will still fit within 160 bits
if status.total_difficulty.bit_len() > 160 {
self.inner.disconnect(DisconnectReason::ProtocolBreach).await?;
return Err(EthHandshakeError::TotalDifficultyBitLenTooLarge {
got: status.total_difficulty.bit_len(),
maximum: 100,
maximum: 160,
}
.into())
}
Expand Down Expand Up @@ -498,7 +498,7 @@ mod tests {
let status = Status {
version: EthVersion::Eth67,
chain: NamedChain::Mainnet.into(),
total_difficulty: U256::from(2).pow(U256::from(100)),
total_difficulty: U256::from(2).pow(U256::from(164)),
blockhash: B256::random(),
genesis,
// Pass the current fork id.
Expand All @@ -522,7 +522,7 @@ mod tests {
assert!(matches!(
handshake_res,
Err(EthStreamError::EthHandshakeError(
EthHandshakeError::TotalDifficultyBitLenTooLarge { got: 101, maximum: 100 }
EthHandshakeError::TotalDifficultyBitLenTooLarge { got: 165, maximum: 160 }
))
));
});
Expand All @@ -539,7 +539,7 @@ mod tests {
assert!(matches!(
handshake_res,
Err(EthStreamError::EthHandshakeError(
EthHandshakeError::TotalDifficultyBitLenTooLarge { got: 101, maximum: 100 }
EthHandshakeError::TotalDifficultyBitLenTooLarge { got: 165, maximum: 160 }
))
));

Expand Down
Loading