feat: Track DA cost in Op Pooled transactions #13806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Jan 17, 2025
crates/optimism/node/src/txpool.rs
Outdated
| pub struct OpPooledTransaction(EthPooledTransaction<OpTransactionSigned>); | ||
| pub struct OpPooledTransaction { | ||
| inner: EthPooledTransaction<OpTransactionSigned>, | ||
| da_cost: U256, |
There was a problem hiding this comment.
ah sorry I wasn't super clear in the issue but for #13757 we don't need cost but gas usage estimation, which should happen lazily, so we need a LazyLock for this instead
estimated_tx_compressed_size: LazyLock<u64>
crates/optimism/node/src/txpool.rs
Outdated
| @@ -296,7 +306,7 @@ where | |||
| /// See also [`TransactionValidator::validate_transaction`] | |||
| /// | |||
| /// This behaves the same as [`EthTransactionValidator::validate_one`], but in addition, ensures | |||
| /// that the account has enough balance to cover the L1 gas cost. | |||
| /// that the account has enough balance to cover the L1 gas cost and DA cost. | |||
There was a problem hiding this comment.
we can undo the changes in validate now because da bytes is unrelated to this
refcell
pushed a commit
to ethereum-optimism/op-reth
that referenced
this pull request
Jan 24, 2025
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #13795