Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit: replace block and sender with RecoveredBlock in ExecutedBlock #13804

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Nit: replace block and sender with RecoveredBlock in ExecutedBlock #13804

merged 4 commits into from
Jan 16, 2025

Conversation

voidash
Copy link
Contributor

@voidash voidash commented Jan 15, 2025 •
edited
Loading

Replaces block and sender with RecoveredBlock.

  • Some other changes include changing the method name block() to recovered_block(). This was done as block().block() is ambigious in some context
  • Instances of Arc and separate senders are refactored into a single Arc.
  • Method clone_recovered_block() removed for direct usage of recovered_block()
    Test cases also updated

closes #13796

@programskillforverification programskillforverification mentioned this pull request Jan 15, 2025
Closed
@voidash voidash changed the title Nit: replace block and sender with RecoveredBlock in ExecutedBlock #13796 Nit: replace block and sender with RecoveredBlock in ExecutedBlock Jan 15, 2025
mattsse
mattsse requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, smol nits.

would appreciate another look by @rkrasiuk @Rjected or @klkvr

crates/storage/provider/src/writer/mod.rs Outdated Show resolved Hide resolved
crates/storage/provider/src/providers/consistent.rs Outdated Show resolved Hide resolved
crates/storage/provider/src/providers/consistent.rs Outdated Show resolved Hide resolved
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Jan 15, 2025
@voidash voidash requested a review from mattsse January 15, 2025 15:21
@mattsse mattsse enabled auto-merge January 16, 2025 15:47
@mattsse mattsse added this pull request to the merge queue Jan 16, 2025
Merged via the queue into paradigmxyz:main with commit 13ecd6a Jan 16, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace senders and block with Recovered block
2 participants
@voidash @mattsse