feat: add execute_single_transaction to BlockExecutionStrategy #13803
+193
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Rjected
force-pushed
the
dan/single-tx-again
branch
from
d372532 to
fab359d
Compare
Rjected
force-pushed
the
dan/single-tx-again
branch
from
fab359d to
b1486fc
Compare
Rjected
requested review from
mattsse,
fgimenez,
rakita and
gakonst
as code owners
fgimenez
approved these changes
Jan 17, 2025
Comment on lines
+158
to
+160
| // The sum of the transaction’s gas limit, Tg, and the gas utilized in this block prior, | ||
| // must be no greater than the block’s gasLimit. | ||
| if transaction.gas_limit() > header.gas_limit { |
There was a problem hiding this comment.
this comment seems out of place, we are executing a single transaction?
Comment on lines
+203
to
+205
| // The sum of the transaction’s gas limit, Tg, and the gas utilized in this block prior, | ||
| // must be no greater than the block’s gasLimit. | ||
| if transaction.gas_limit() > header.gas_limit() && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
execute_single_transactionto theBlockExecutionStrategytrait. If we then expose this from an executor, it unblocks prewarming, which must execute individual transactions