Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove blockchaintree dep from reth bin #13712

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 7, 2025

this removes blockchaintree dep from reth bin crate

this drops the engine replay command because this can also be implemented as command that replays the engine messages over rpc which I think is easier to maintain

@mattsse mattsse added the A-sdk Related to reth's use as a library label Jan 7, 2025
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just needs book cli update i think

@mattsse mattsse enabled auto-merge January 7, 2025 21:16
@mattsse mattsse added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 027f80e Jan 7, 2025
43 checks passed
@mattsse mattsse deleted the matt/rm-blockchaintree-dep-from-reth-bin2 branch January 7, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants