Discussion draft: change DB Writer to take value references #13672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
requested review from
rkrasiuk,
Rjected,
shekhirin,
joshieDo,
rakita,
onbjerg and
fgimenez
as code owners
|
CI passing and ready for consideration |
|
cc @hai-rise in case you wanna bench it |
gakonst
reviewed
Jan 6, 2025
| StorageTrieEntry { nibbles, node: node.clone() }, | ||
| &StorageTrieEntry { nibbles, node: node.clone() }, |
There was a problem hiding this comment.
could this potentially be StorageTrieEntryRef so that node is not cloned either?
There was a problem hiding this comment.
yeah this will be unlocked by this
mattsse
approved these changes
Jan 6, 2025
Comment on lines
+197
to
+198
| fn compress_to_buf<B: bytes::BufMut + AsMut<[u8]>>(&self, buf: &mut B) { | ||
| let _ = Compact::to_compact(self, buf); |
There was a problem hiding this comment.
yeah this was the reason why we originally had it as self and Value
joshieDo
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following changes:
insert,upsertandappendto take a&T::Valueinstead ofT::Value.StateWriterto not take ownership of (potentially large?)ExecutionOutcome