-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(primitives): re-export alloy Recovered #13670
feat(primitives): re-export alloy Recovered #13670
Conversation
9fffc2c
to
77f476a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome,
this looks great the ci failure
thread 'tokio-runtime-worker' has overflowed its stack
indicates that there is some recursion happening, likely when doing some conversion
makes sense, we can do that separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! amazing
one step closer
The second part of #13651
RecoveredTx
alloy::consensus::Recovered as RecoveredTx
, in order to replace the rethRecoveredTx
impl
for foreign typeNote that I didn't impl the step "remove extension trait and integrate these functions in SignedTransaction directly", because I didn't see the reason to do that.