Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement "Add BlockBody::transaction_count helper function" #13660

Merged
merged 3 commits into from
Jan 5, 2025
Merged

feat: Implement "Add BlockBody::transaction_count helper function" #13660

merged 3 commits into from
Jan 5, 2025

Conversation

frankudoags
Copy link
Contributor

Closes #13639

PR Checklist:

  • introduce these two functions (trait + native on SealedBlock)
  • simplify .body().transactions().len() with .transaction_count

@frankudoags frankudoags mentioned this pull request Jan 5, 2025
Closed
2 tasks
@mattsse mattsse enabled auto-merge January 5, 2025 14:12
@mattsse mattsse added this pull request to the merge queue Jan 5, 2025
Merged via the queue into paradigmxyz:main with commit f4ce10b Jan 5, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BlockBody::transaction_count helper function
2 participants
@frankudoags @mattsse