Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ci): remove moved deny workflow #13645

Merged
merged 1 commit into from
Jan 4, 2025
Merged

docs(ci): remove moved deny workflow #13645

merged 1 commit into from
Jan 4, 2025

Conversation

TiesD
Copy link
Contributor

@TiesD TiesD commented Jan 4, 2025

  • Removed the deny workflow from docs as it was moved under the lint workflow in ci: move deny to lint #13230
  • Since lint description already mentions "other checks", don't think it's necessary to mention deny there

@TiesD TiesD requested a review from gakonst as a code owner January 4, 2025 01:49
@@ -15,8 +15,6 @@ The CI runs a couple of workflows:
- **[book]**: Builds, tests, and deploys the book.

### Meta

- **[deny]**: Runs `cargo deny` to check for license conflicts and security advisories in our dependencies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to the Linting and Checks section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would that make sense though since the deny.yml file no longer exists, instead it's under lint.yml and being pulled from here

@mattsse mattsse added the A-ci Related to github workflows or other build and lint tools label Jan 4, 2025
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, yeah we dont really need to list this

@mattsse mattsse enabled auto-merge January 4, 2025 13:34
@mattsse mattsse added this pull request to the merge queue Jan 4, 2025
Merged via the queue into paradigmxyz:main with commit 2c94d7b Jan 4, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Related to github workflows or other build and lint tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants