Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify transaction to call request conversion #13574

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

@mattsse mattsse requested a review from Rjected as a code owner December 28, 2024 10:13
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Dec 28, 2024
@mattsse mattsse enabled auto-merge December 28, 2024 10:14
Copy link

codspeed-hq bot commented Dec 28, 2024

CodSpeed Performance Report

Merging #13574 will degrade performances by 10.17%

Comparing matt/simplify-recovered-tx-to-tx-request (bcb3f1b) with main (91dd417)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 74 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main matt/simplify-recovered-tx-to-tx-request Change
`hash builder[init size 10000 update size 100 num updates 1]` 9.1 ms
`receipts root size: 10 HashBuilder` 119.5 µs
ordered_trie_root 139.7 µs 125.4 µs +11.46%

@mattsse mattsse disabled auto-merge December 29, 2024 13:32
@mattsse mattsse merged commit 86e383f into main Dec 29, 2024
43 of 44 checks passed
@mattsse mattsse deleted the matt/simplify-recovered-tx-to-tx-request branch December 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant