refactor: avoid using NoopTransactionPool in OP payload builder #13547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now OP payload builder depends on
NoopTransactionPool
tx type when building empty payloads or constructing witnesses. This is unconvinient because we don't know thePoolTransaction
AT thereThis PR changes logic to operate on a simple closure
BestTransactionsAttributes
-> iterator which may optionally capture and use the pool. That way for building a payload without external transactions we no longer need to mock the poolLikely a nicer solution could be to force payload builders to hold a pool, this would also allow simplifying the
BuildArguments
struct although has other implications as this would leak pool generic to some rpc types which deal directly with payload builder