Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump alloy-trie and nybbles #13502

Merged
merged 1 commit into from
Dec 22, 2024
Merged

chore: bump alloy-trie and nybbles #13502

merged 1 commit into from
Dec 22, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 22, 2024

prep for #13501

@mattsse mattsse requested a review from gakonst as a code owner December 22, 2024 18:56
@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Dec 22, 2024
@mattsse mattsse requested review from DaniPopes and removed request for gakonst December 22, 2024 18:57
Copy link

codspeed-hq bot commented Dec 22, 2024

CodSpeed Performance Report

Merging #13502 will degrade performances by 10.74%

Comparing fix/bump-nybbles (93c15fb) with main (369d745)

Summary

❌ 1 regressions
✅ 72 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/bump-nybbles Change
any lookup` 4.9 µs 5.5 µs -10.74%
🆕 range lookup` N/A 608.9 µs N/A
🆕 any lookup` N/A 19.8 ms N/A
🆕 `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
⁉️ range lookup` 610.6 µs N/A N/A
⁉️ any lookup` 19.9 ms N/A N/A
⁉️ `prefix set preload size: 1000 input size: 999 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 999 Vec with custom cursor lookup`

@mattsse mattsse merged commit 0a5e430 into main Dec 22, 2024
43 of 44 checks passed
@mattsse mattsse deleted the fix/bump-nybbles branch December 22, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant