Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use batch tx validation in eth validator #13490

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

stevencartavia
Copy link
Contributor

should close #13383

Copy link

codspeed-hq bot commented Dec 21, 2024

CodSpeed Performance Report

Merging #13490 will not alter performance

Comparing stevencartavia:tx-val-batch (0650817) with main (50dfd30)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main stevencartavia:tx-val-batch Change
⁉️ `prefix set preload size: 1000 input size: 1000 BTreeSet with BTreeSet:range lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 BTreeSet with Iterator:any lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
🆕 `prefix set preload size: 1000 input size: 999 BTreeSet with BTreeSet:range lookup`
🆕 `prefix set preload size: 1000 input size: 999 BTreeSet with Iterator:any lookup`
🆕 `prefix set preload size: 1000 input size: 999 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 999 Vec with custom cursor lookup`

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool,
nits

crates/transaction-pool/src/validate/eth.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/validate/eth.rs Show resolved Hide resolved
@mattsse mattsse marked this pull request as ready for review December 23, 2024 07:12
@mattsse mattsse added A-tx-pool Related to the transaction mempool C-perf A change motivated by improving speed, memory usage or disk footprint labels Dec 23, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

I changed the if let Some(state) = state because I prefer an is_nonce check instead.

FYI @hai-rise

@mattsse mattsse enabled auto-merge December 23, 2024 18:46
@mattsse mattsse added this pull request to the merge queue Dec 23, 2024
Merged via the queue into paradigmxyz:main with commit 3e15ae3 Dec 23, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use batch tx validation in eth validator
2 participants