chore: move database to FullNodeTypes #13414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
onbjerg,
emhane,
shekhirin and
gakonst
as code owners
mattsse
approved these changes
Dec 16, 2024
Comment on lines
+27
to
+31
| type Types: NodeTypesWithEngine; | ||
| /// Underlying database type used by the node to store and retrieve data. | ||
| type DB: Database + DatabaseMetrics + DatabaseMetadata + Clone + Unpin + 'static; | ||
| /// The provider type used to interact with the node. | ||
| type Provider: FullProvider<Self::Types>; | ||
| type Provider: FullProvider<NodeTypesWithDBAdapter<Self::Types, Self::DB>>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
FullNodeTypes::Typesare set toNodeTypesWithDBAdaptermost of the time, making it impossible to bound likeTypes = EthereumNodeThe reason
NodeTypesWithDBexists is so that we can avoid having both db and NodeTypes generics on types depending on ProviderFactory, so we can't just get rid of it. Instead, this PR makes it a responsibility of NodeBuilder to assemble NodeTypesWithDBAdapter, keeping user-configured NodeTypes in FullNodeTypes