Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm evm_env_for_raw_block function #13403

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 14, 2024

this function is pretty much redundant.

and the workaround going through the parent header is only necessary due to the total difficulty.

we can use the the provided header directly because we assume the given block has a height <= latest

@mattsse mattsse force-pushed the matt/rm-evm_env_for_raw_block branch from c1364fb to fbbc1cd Compare December 14, 2024 11:38
@mattsse mattsse added the A-rpc Related to the RPC implementation label Dec 14, 2024
@mattsse mattsse enabled auto-merge December 14, 2024 17:21
@mattsse mattsse added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 4e6ed39 Dec 16, 2024
42 checks passed
@mattsse mattsse deleted the matt/rm-evm_env_for_raw_block branch December 16, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants