Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Introduce helper type for evm cfg and env tuple #13377

Merged
merged 9 commits into from
Dec 14, 2024

Conversation

TheDhejavu
Copy link
Contributor

@TheDhejavu TheDhejavu commented Dec 13, 2024

Should resolve: #13340

I think i over did some stuff because I touched a lot of files in an attempt to consolidate every related evm env calls that returns (CfgEnvWithHandlerCfg, BlockEnv) to EvmEnv.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,

as expected this ripples through the codebase, but we need to lock down revm types access first and imo this is a necessary first step.

wdyt @Rjected @klkvr

@mattsse mattsse added the A-execution Related to the Execution and EVM label Dec 13, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse added this pull request to the merge queue Dec 14, 2024
Merged via the queue into paradigmxyz:main with commit b525231 Dec 14, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce helper type for evm cfg and env tuple
3 participants