chore: remove the workaround for pre-bedrock OP transactions #13365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
Rjected,
emhane,
mattsse and
fgimenez
as code owners
mattsse
approved these changes
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes hack for decoding of legacy transaction signature used for decoding of OP transactions.
This PR is based on assumption that this decoding should never happen during op-reth node operation. If such transaction is imported during pipeline sync of pre-bedrock blocks it will just fail the recovery stage, and during manual import no transactions are being imported
Additionally changed the transaction decoding to not compute hashes
cc @emhane @joshieDo