Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add OmmersProvider trait #13331

Merged
merged 1 commit into from
Dec 12, 2024
Merged

chore: add OmmersProvider trait #13331

merged 1 commit into from
Dec 12, 2024

Conversation

joshieDo
Copy link
Collaborator

Moves fn ommers away from trait BlockReader into trait OmmersProvider

@joshieDo joshieDo added C-enhancement New feature or request A-sdk Related to reth's use as a library labels Dec 12, 2024
@joshieDo joshieDo requested review from mattsse and klkvr December 12, 2024 00:19
klkvr
klkvr approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 7764b9a Dec 12, 2024
43 checks passed
@mattsse mattsse deleted the joshie/ommers branch December 12, 2024 11:43
emhane pushed a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024
@joshieDo @emhane
chore: add OmmersProvider trait (paradigmxyz#13331)
ef59082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshieDo @mattsse @klkvr