chore: rm receiptsext trait #13296
Merged
chore: rm receiptsext trait #13296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
Rjected,
emhane,
joshieDo,
klkvr,
rakita,
rkrasiuk and
fgimenez
as code owners
klkvr
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this trait was pretty much useless because it didn't allow the OP specific receipt root.
renamed the function that relied on this for clarity.
we can also remove this fn from
ExecutionOutcomewhich only has an additional helper (can remove separately after relaxingcalculate_receipt_root_no_memo)where this is still problematic is in the reorg tester code, only for those usecases we'd need an abstraction that can do both OP and eth, but since this is only really used for eth testing this should be okay, it would have paniced before this pr.