chore: reduce revm scope in txpool #13274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/reduce-revm-deps-on-pool
branch
from
7078ea9 to
37cd874
Compare
mattsse
requested review from
Rjected,
onbjerg,
emhane and
klkvr
as code owners
mattsse
force-pushed
the
matt/reduce-revm-deps-on-pool
branch
from
7d3d499 to
9141db7
Compare
emhane
approved these changes
Dec 11, 2024
| @@ -807,6 +803,7 @@ pub fn ensure_intrinsic_gas<T: EthPoolTransaction>( | |||
| transaction: &T, | |||
| fork_tracker: &ForkTracker, | |||
| ) -> Result<(), InvalidPoolTransactionError> { | |||
| use revm_primitives::SpecId; | |||
There was a problem hiding this comment.
how come this use statement is local to this function?
There was a problem hiding this comment.
I want to limit revm imports to only this function, because this is the only place we're using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we only need this to pre-validate gas limits, but we can reduce imports