Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused evm env provider fns #13272

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 10, 2024

none of those were really used we only need:

        let total_difficulty = self
            .header_td_by_number(header.number())?
            .ok_or_else(|| ProviderError::HeaderNotFound(header.number().into()))?;
        Ok(evm_config.cfg_and_block_env(header, total_difficulty))

this additional trait is only necessary because we need to lookup the total difficulty, and even this we need to remove as prep for state expiry (cc @joshieDo )

so ideally we phase out this entire trait, if we can track all fork ttd statically

@mattsse mattsse added C-debt A clean up/refactor of existing code A-execution Related to the Execution and EVM labels Dec 10, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@mattsse mattsse force-pushed the matt/remove-unused-evm-env-provider-fns branch from 7ec505b to 15e0968 Compare December 10, 2024 14:39
@mattsse mattsse enabled auto-merge December 10, 2024 15:04
@mattsse mattsse added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 62e2cbf Dec 10, 2024
42 checks passed
@mattsse mattsse deleted the matt/remove-unused-evm-env-provider-fns branch December 10, 2024 18:58
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants