Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use constructor functions #13255

Merged
merged 2 commits into from
Dec 11, 2024
Merged

refactor: use constructor functions #13255

merged 2 commits into from
Dec 11, 2024

Conversation

faheelsattar
Copy link
Contributor

Closes #13247

mattsse
mattsse requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,

I'd like to limit these to one specific change at a time

crates/engine/tree/src/tree/mod.rs Outdated Show resolved Hide resolved
crates/consensus/beacon/src/engine/mod.rs Outdated Show resolved Hide resolved
mattsse
mattsse approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! ty

next step is making the fields private and adding getters and functions that consume the individual fields so we can avoid clones

@mattsse mattsse added this pull request to the merge queue Dec 11, 2024
Merged via the queue into paradigmxyz:main with commit 6b7bf2a Dec 11, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@klkvr klkvr Awaiting requested review from klkvr

@onbjerg onbjerg Awaiting requested review from onbjerg

@shekhirin shekhirin Awaiting requested review from shekhirin

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@fgimenez fgimenez Awaiting requested review from fgimenez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always use constructor functions for block types
2 participants
@faheelsattar @mattsse