Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(validate-tx-pool): fast non-allocating is_local #13096

Merged
merged 1 commit into from
Dec 3, 2024
Merged

perf(validate-tx-pool): fast non-allocating is_local #13096

merged 1 commit into from
Dec 3, 2024

Conversation

hai-rise
Copy link
Contributor

@hai-rise hai-rise commented Dec 3, 2024 •
edited
Loading

Towards #12838.

mattsse
mattsse requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very invasive because most callsites actually need a copy.

this also mixes some txpool API changes in there,

so I'd suggest an alternative approach here:

add fn signer_ref(&self) -> &Addr and use that function where we can

wdyt @Rjected @klkvr

@hai-rise
Copy link
Contributor Author

hai-rise commented Dec 3, 2024

@mattsse Ah that's a good suggestion. Let me do it and focus on pool tx validation first :).

@hai-rise hai-rise changed the title perf(RecoveredTx): return sender as reference perf(validate-tx-pool): fast non-allocating is_local Dec 3, 2024
mattsse
mattsse approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot easier to review hehe

ty

@mattsse mattsse added this pull request to the merge queue Dec 3, 2024
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-tx-pool Related to the transaction mempool labels Dec 3, 2024
Merged via the queue into paradigmxyz:main with commit 7008ac2 Dec 3, 2024
41 checks passed
@hai-rise hai-rise deleted the sender-ref branch December 3, 2024 15:33
@hai-rise
Copy link
Contributor Author

hai-rise commented Dec 3, 2024

a lot easier to review hehe

ty

And I get a new contribution counted per PR 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@rakita rakita Awaiting requested review from rakita

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hai-rise @mattsse