Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(engine): do not clone proof targets #13061

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Dec 2, 2024

Update the fetched proof targets map by passing it as a mutable reference to avoid cloning.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-trie Related to Merkle Patricia Trie implementation labels Dec 2, 2024
@shekhirin shekhirin closed this Dec 2, 2024
@shekhirin shekhirin changed the title fix(engine): proof targets update race perf(engine): do not clone proof targets Dec 2, 2024
@shekhirin shekhirin reopened this Dec 2, 2024
@shekhirin shekhirin marked this pull request as ready for review December 2, 2024 16:13
@shekhirin shekhirin added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit a8feec8 Dec 3, 2024
83 checks passed
@shekhirin shekhirin deleted the alexey/state-root-task-proof-targets-race branch December 3, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants