Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add encodable to pooled recovered #12866

Merged
merged 1 commit into from
Nov 26, 2024
Merged

chore: add encodable to pooled recovered #12866

merged 1 commit into from
Nov 26, 2024
+19 −1

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 26, 2024

adds encoable to the recovered variant.

this makes:

reth/crates/rpc/rpc-eth-api/src/helpers/transaction.rs

Line 105 in feb32a6

self.pool().get_pooled_transaction_element(hash).map(|tx| tx.encoded_2718().into())

easier to use and we expect that this is an encodable type

@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Nov 26, 2024
@mattsse mattsse enabled auto-merge November 26, 2024 10:31
@mattsse mattsse added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 1b4048e Nov 26, 2024
41 checks passed
@mattsse mattsse deleted the matt/add-encodable-to-pooled-recovered branch November 26, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk