Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run upkeep manually #12664

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: run upkeep manually #12664

merged 1 commit into from
Nov 19, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 19, 2024

closes #12283

because we use PrometheusBuilder::new().build_recorder() we must run upkeep manually

@mattsse mattsse force-pushed the matt/ensure-we-call-upkeep branch from 34ab56a to 252d99c Compare November 19, 2024 14:46
@mattsse mattsse requested a review from rkrasiuk November 19, 2024 14:46
@github-actions github-actions bot added the C-bug An unexpected or incorrect behavior label Nov 19, 2024
@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Nov 19, 2024
@mattsse mattsse force-pushed the matt/ensure-we-call-upkeep branch from 252d99c to 25eb896 Compare November 19, 2024 14:52
@mattsse mattsse force-pushed the matt/ensure-we-call-upkeep branch from 25eb896 to 423c196 Compare November 19, 2024 14:54
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 66a9d3e Nov 19, 2024
40 checks passed
@mattsse mattsse deleted the matt/ensure-we-call-upkeep branch November 19, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak when metrics endpoint is enabled, but not scraped
2 participants